How can we improve Team Services?

TFS code review should not require a new code review to be started when code that is already under review is changed based on review comment

It seems that TFS requires a new code review to be started whenever code that is already under review is updated in response to review comments. It is not only unnecessary busy work for a developer to initiate a new review each time a review comment would suggest a change to the code that is already under review is necessary, but it also prevents having a single picture of changes made as a result of the review process.

With the current method, a single logical code review may span multiple physical code reviews and the comments for the single logical review are fragmented across several physical reviews.

2,359 votes
Vote
Sign in
Check!
(thinking…)
Reset
or sign in with
  • facebook
  • google
    Password icon
    I agree to the terms of service
    Signed in as (Sign out)
    You have left! (?) (thinking…)
    MichaelMichael shared this idea  ·   ·  Flag idea as inappropriate…  ·  Admin →

    61 comments

    Sign in
    Check!
    (thinking…)
    Reset
    or sign in with
    • facebook
    • google
      Password icon
      I agree to the terms of service
      Signed in as (Sign out)
      Submitting...
      • Sina JazayeriSina Jazayeri commented  ·   ·  Flag as inappropriate

        For those waiting, we gave up waiting and invested in Smatbear Collaborater which offers iterative changes and integrates well with TFS. It's clear TFVC is no longer treated as high priority by MS.

      • NoelNoel commented  ·   ·  Flag as inappropriate

        This is so pathetic, you need to implement this immediately. We have been waiting forever.

      • Doug WaterfieldDoug Waterfield commented  ·   ·  Flag as inappropriate

        I have recently begun leading a team that has been using TFSVC for a while. I'm really surprised that such a basic workflow isn't available!

        When will this be in the product?

      • Michael DenholmMichael Denholm commented  ·   ·  Flag as inappropriate

        Considering its now 15 months later and a new version of TFS recently released, should I assume this will never be implemented in TFVC, give up on it and move to Git?

      • Anonymous commented  ·   ·  Flag as inappropriate

        You are too late! Who in their right mind will use a CR tool that requires a new CR to be started after reflecting even a single comment ???

      • Rob SiklosRob Siklos commented  ·   ·  Flag as inappropriate

        @Andrew Ch: This is not a a reliable of doing things. The problem is that as the comments get addressed, the line numbers change, and you complete lose sight of what the original code review captured.

        @80's Rocker: Couldn't agree more, but the writing is clearly on the wall - TFSVC is dead, and too bad for all of us that are using it. I guess we're just expected to migrate to Git or stay with TFSVC and live with a reduced feature set. I wish they'd just come right out and say this. At the end of the day, it seems the mob has spoken and Git is the winner.

      • 80's Rocker80's Rocker commented  ·   ·  Flag as inappropriate

        This is really sad that it on 1/15/16 this was still not on the roadmap to be implemented. Greate feature is being killed by poor implementation and not fixing a glaring feature shortcoming in a timeley mannner. The VS team obviosly uses GIT and that is why getting this implemented in GIT was a big priority instead of TFS. But by doing that they are ignoring a very big user base of TFS who don'want to switch over to GIT.

      • Andrew ChAndrew Ch commented  ·   ·  Flag as inappropriate

        There seems to be a way of doing this already -- if you make your changes in response to the code review, and then save the changes back to the shelveset (set the name to the same name of the shelve set used for the code review).

      • ScottScott commented  ·   ·  Flag as inappropriate

        I agree with Joshua, moving to git is just not an option for us at this point. We have many in house build process(es) built on top of tfs vc. This really needs to be planned and implemented and not just abandoned for git.

      • Brendan H.Brendan H. commented  ·   ·  Flag as inappropriate

        Just a comment that this is working well for us now using TFS Git on premise! We do not use TFVC.

      • Vito DeCarloVito DeCarlo commented  ·   ·  Flag as inappropriate

        I agree. I'm not against git, but if that's where everything is heading, I'd just assume migrate now and get it over with.

      • StephenStephen commented  ·   ·  Flag as inappropriate

        Am I reading this right? That this is being done for Git, but not TFVC?

        If so, I am a bit concerned. I did not believe the "TFVC is dying" statements. But if this is being done for Git and is not even road-mapped for TFVC, well that looks bad.

        Makes it looks as if TFVC is a "second class" member of the team. At best.

      • Keith CulpepperKeith Culpepper commented  ·   ·  Flag as inappropriate

        Any update on this? I agree that the code review should be updated instead of having to create a new review.

      • David CoulterDavid Coulter commented  ·   ·  Flag as inappropriate

        Put hover text on ALL grayed out items, so we will know how to ungray them and use them!!! you can start with "Request Review".

      ← Previous 1 3 4

      Feedback and Knowledge Base