693 votesunder review · 23 comments · Visual Studio IDE » Extensibility · Flag idea as inappropriate… · Admin →
With TFS embracing subversion it would make sense to support svn for code lens as well.
Ohh and another few would be: * application insights information (exceptions, performance hotspots)
* incoming changes (shelvesets)
* I'm not a fan of other ticket systems integrations, but I can see that others may see value. Problem will probably be detecting the proper link to the code items.
* integration in 3rd party code review systems (smartbear)
* show code review comments of open reviews.
* mixed social integrations including skype, hangouts, skype for business at least. Not all teams use Skype for business exclusively, especially in open source scenarios.
* GitHub issues integration
* incoming changes support for git. Including origin, and pull requests (GitHub forks)
* show compiled html help
* SonarQube statistics
* file level indicators for non-c#/vb
* incoming changes for tfvc shelve sets
* code navigation for virtual/interface methods. Goto base implementation, find all implementors
* code health indicator (make it a feature)
* build / Roslyn analyzer warning indicator (simple icon)
* suppressed warnings indicator
30 votesunder review · 0 comments · Visual Studio IDE » Version Control (Git/TFVC) · Flag idea as inappropriate… · Admin →
Hold down [ALT] each lens will show a number (2 for references for example). This will directly open that lens.
[ALT]+[->] and [ALT]+[<-] allows you to navigate between lenses
Once a lens is opened you can use arrow-up/down to navigate the lens content.
This should be fairly simple to implement using a MsBuild target and adding a list of disallowed words to the msbuild.exe command line. How do you envision these 'bad words' to be defined? Is it a short list of strings? Or does their location inside the source make them more or less important? (Parsing the sources and ensuring these only occur inside the comments is more work ;).
See the TEK WorkItem Toolkit for a addon to Visual Studio that provides such functionality for TFS 2010 and soon also for 2012. http://visualstudiogallery.msdn.microsoft.com/1397f185-7f49-49c8-ad80-e45fc9dbbfe9
We have a lot of investment taking place on our code review platform that will enable iterative code reviews, and we will initially bring that functionality to Git (via pull requests). Improving iterative code reviews for TFVC is still on our backlog, but it is not in our 6 month plan, so we are resetting the status.
There is a work around to allow us to review arbitrary code, code for a specific work item etc. It's just well hidden. Start with a standard workspace, nothing checked out etc. Now in the Source Control Explorer rightclick/checkout any file(s) you want reviewed. Use the Request Review feature. Even though you haven't made any changes, the files will now be added to a review request. and you can submit the review just as any other.
The disadvantage of this technique is that you won't see the changes between this version and an older version when clicking the source file during the review, but you can still comment on it easily.
Comments based upon your request:
1) Agreed, would love Review integration into Team Web Access, but keep in mind that the code review feature also allows review of Design surfaces, which will be troublesome in a web interface. A limited version that allows reviewing of plain text items is something I'd want as well.
2) You can request post-commit reviews of a ChangeSet by going to the History window, rightclicking a changeset and choosing "Request Review". This is not yet possible by work item unfortunately.
3) This was a deliberate choice from the team if I understood correctly. Discussions should take place face to face, on the phone, through screenshare etc. Not through the work item database. I tend to agree.
4) Agreed! Need that :)
I'd like to add a few points:
5) Allow us to perform the code review offline. From Visual Studio select the review requests and bring them to my local system. Provision workspaces with the correct versions and prepare the shelvesets locally. Now let me do my reviews and create the review response items offline. When I go back online, push the review responses out to the work item store.
6) Allow us to review arbitrary code. Instead of requesting a review of a code file or a changeset or a work item, allow us to request a review for a solution, a branch, a source control folder in TFS etc. This would allow recorded audits by non-team members with TFS access.
7) Allow the creation of a Review Response without first requesting a review. Sometimes a review is just 'done' when it's 'done'. Not part of a specific process or anything. Someone just decides to do a review. I'd like to be able to use this feature without having to request review. I'd like to be able to 'do a review' and then assign the results to someone. If needed create a review request under the covers.
As we investigate this proposed model, we have a general question for you.
1. We support Undo stacks in the tool.
2. There is an extension “auto-history” that provides a level of automatic roll-back, based on heuristics/events to perform snapshots
3. Local repo support.
If we think of the above as a continuum from simple undo to a more explicit commit, we would like to hear feedback on how you’d prefer a model for local history support on this spectrum. E.g. is the preferred model to allow automatic snapshotting to a local repo?Jesse Houwing supported this idea ·