Peter Kurlak

My feedback

  1. 405 votes
    Sign in
    or sign in with
    • facebook
    • google
      Password icon
      Signed in as (Sign out)

      We’ll send you updates on this idea

      Peter Kurlak supported this idea  · 
      Peter Kurlak commented  · 

      Not having this feature prevents taking advantage of the true power of the Git workflow: being able to work on and receive reviews for multiple things at once. Before I knew of this limitation, I created a PR against a branch other than master. It was awesome! My coworkers were able to provide feedback on code that depended on another branch not yet in master. After some dialog, they approved my changes. When I had received all my approvals and the owner was ready to review, I suddenly discovered this problem. Now I had to "throw" away a perfectly good PR and create a new one against master. The comments and approvals obviously did not transfer. Thus, I had to ping everyone that had previously approved the code to do so AGAIN (developers hate repetition), and then the code's owner had to reference the previous PR. And what if he wanted to add comments? Should they go on the previous PR or the new PR? What a mess. This needs to be fixed ASAP!

    Feedback and Knowledge Base