Anonymous

My feedback

  1. 166 votes
    Sign in
    (thinking…)
    Sign in with: facebook google
    Signed in as (Sign out)

    We’ll send you updates on this idea

    Anonymous commented  · 

    Also want this!

  2. 110 votes
    Sign in
    (thinking…)
    Sign in with: facebook google
    Signed in as (Sign out)

    We’ll send you updates on this idea

    We’re starting to take a look at this feature, and have some questions about exactly what people are expecting from this suggestion.

    Currently, the pull-request diff experiences ignore leading and trailing whitespace by default. For example, if only the indentation of a line changed, that line will not be highlighted as having any changes. This leads us to believe that this suggestion is about some other whitespace diffing behavior.

    We have some ideas about what this might mean, but we want to hear from our users. If you have any insights you wish to share to help us better understand this suggestion, please reply to this email and let us know.

    Thank you!

    Anonymous commented  · 

    When reviewing PRs, some changes can be pure whitespace formatting changes... such as:

    if (something) -> if ( something )

    It would be very useful to have the option to ignore (or not) these changes when reviewing pull requests.

    I think all whitespace should be treated the same in this regard (leading, trailing, mid-line, etc) -- have the ability to ignore all of it or none of it.

    Also, keep in mind that indentation matters for languages like Python, so you shouldn't ignore such changes by default...

    Anonymous supported this idea  · 
  3. 34 votes
    Sign in
    (thinking…)
    Sign in with: facebook google
    Signed in as (Sign out)

    We’ll send you updates on this idea

    Anonymous supported this idea  · 
  4. 5 votes
    Sign in
    (thinking…)
    Sign in with: facebook google
    Signed in as (Sign out)

    We’ll send you updates on this idea

    Anonymous supported this idea  · 

Feedback and Knowledge Base